refactor(useKeydown): optimize keydown event handling #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
reviewed
Jul 2, 2025
johnleider
reviewed
Jul 11, 2025
| } | ||
|
|
||
| if (getCurrentScope()) { | ||
| const stopListening = () => { |
There was a problem hiding this comment.
What is your philosophy behind const functions and when to use them?
There was a problem hiding this comment.
I used to write functions via const, but on top level it's converted by antfu eslint plugin automatically, unlike nesting 🥲
johnleider
requested changes
Aug 12, 2025
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
commit: |
J-Sek
requested changes
Sep 2, 2025
| function startGlobalListener () { | ||
| if (typeof document === 'undefined') return | ||
|
|
||
| if (!globalListener) { |
There was a problem hiding this comment.
whenever if { ... } guards most of the logic within a function it should be replaced with early exit if (!..) return, so we avoid unnecessary indentation and the inner logic is easier to read/scan-through.
There are 3 methods here that would benefit from this quick refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use registrar and single event listener to listen to keydown in a more performant way